Add nodeset prefix to nodeset types #4371
Open
+30
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I try to use nodeset for example TESTNODESET1 with type Point and the other nodeset TESTNODESET2 with different type Point I've get UA_Point in first case and also UA_Point and the second. So it will be two declaration of two different types with the same name.
I think thats wrong...
I'm suggest add nodeset prefix to all nodet types (except ns0).
In that case I will get in C code two declaration of two different types UA_TESTNODESET1_Point and UA_TESTNODESET2_Point.