Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeset prefix to nodeset types #4371

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Johnsik
Copy link
Contributor

@Johnsik Johnsik commented Apr 27, 2021

If I try to use nodeset for example TESTNODESET1 with type Point and the other nodeset TESTNODESET2 with different type Point I've get UA_Point in first case and also UA_Point and the second. So it will be two declaration of two different types with the same name.
I think thats wrong...
I'm suggest add nodeset prefix to all nodet types (except ns0).
In that case I will get in C code two declaration of two different types UA_TESTNODESET1_Point and UA_TESTNODESET2_Point.

@Johnsik Johnsik closed this Apr 27, 2021
@Johnsik Johnsik reopened this Apr 27, 2021
@GoetzGoerisch
Copy link
Contributor

@Johnsik why do you need this?

For normative NodeSets this behavior would be harmful?

@Johnsik
Copy link
Contributor Author

Johnsik commented May 2, 2021

@Johnsik why do you need this?

For normative NodeSets this behavior would be harmful?

No. It will affected only to C names.

@Johnsik Johnsik closed this Jun 4, 2021
@Johnsik Johnsik reopened this Jun 4, 2021
@andreasebner andreasebner added the Component: Nodeset Compiler Issues related to the nodeset compiler label May 5, 2022
@NoelGraf
Copy link
Member

NoelGraf commented Jun 2, 2022

@jpfr
Is there something that prevents us from having the same type in two nodesets? If not, we should include this change. What do you think?

@Johnsik
Copy link
Contributor Author

Johnsik commented Jun 2, 2022

Is there something that prevents us from having the same type in two nodesets? If not, we should include this change. What do you think?

Sorry, my I correct you. Not the same type in two node sets, but the two different types with same non-qualified name in two nodesets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Nodeset Compiler Issues related to the nodeset compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants