Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] doc(pack): add conan package documentation #3659

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

saukijan
Copy link

@saukijan saukijan commented Jun 2, 2020

Description

This PR adds documentation for the open62541 conan package found at conan-center-index

It should not be merged until the following is complete:

@saukijan saukijan changed the title doc(pack): add conan package documentation [Review] doc(pack): add conan package documentation Jun 2, 2020
@jpfr
Copy link
Member

jpfr commented Jun 2, 2020

Thanks. Just a typo:

This setting supprots the following options:

@saukijan
Copy link
Author

saukijan commented Jun 2, 2020

Thanks @jpfr for the quick review! I will move it to WIP now and when in its ready Ill put it back to review!

@saukijan saukijan changed the title [Review] doc(pack): add conan package documentation [WIP] doc(pack): add conan package documentation Jun 2, 2020
@jpfr
Copy link
Member

jpfr commented Jun 3, 2020

This can be merged. Ready?

@saukijan
Copy link
Author

saukijan commented Jun 3, 2020

Well the PR at conan central index: conan-io/conan-center-index#1687 still needs reviews, and if for some reason it gets rejected I would need to edit this PR with some new information, so I would say that it is not ready.

@saukijan saukijan changed the title [WIP] doc(pack): add conan package documentation [Review] doc(pack): add conan package documentation Dec 10, 2020
@saukijan
Copy link
Author

the latest releases (1.0.6 and 1.1.5) are available at conan central index, this PR can be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants