[Review] feat(plugin): implement configurable logger for pki_default unit #3567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the use of the standard log_stdout.h from ua_pki_default.c and implements the use of a more generalized log.h in its place.
This is achieved by using a
static UA_Logger
variable, which is initially set toNULL
and set during configuration by one of the following functions:UA_CertificateVerification_AcceptAll()
UA_CertificateVerification_Trustlist()
UA_CertificateVerification_CertFolders()
A
NULL
logger is acceptable since log.h checks against it, and if it is found, no logging is done, which in principal, allows for full deactivation of the logging plugin during the configuration process.