feat(server): Integrate node id header generation into nodeset compiler #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 814fbac into 073f417 - view on LGTM.com new alerts:
|
bfddfff
to
93be017
Compare
|
Cool! |
93be017
to
b13d02a
Compare
9fbde35
to
58525ba
Compare
58525ba
to
f1f3598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional capabilities to the nodeset compiler to generated nodeid defines directly out of the NodeSet2.xml file.
With this PR we can gradually remove the generate_nodeid_header.py script and with that the dependency to have a
.csvfile for everyNodeSet2.xml.There's still the issue that the node id names of NS0 in the .csv are sometimes arbitrarily named and can not be automatically generated.
Tested with DI and other nodesets this change generates mostly similar define names.