Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: dark mode styles on <MonsterFilterBox> and <MagicItemFilterBox> #517

Closed
calumbell opened this issue Jun 21, 2024 · 1 comment
Closed

Comments

@calumbell
Copy link
Contributor

Description

The <MonsterKilterBox> and <MagicItemFilterBox> do not look right on dark mode. The text colour changes from black to white, but none of the background colours of the form elements change. This results in unreadible text due to low colour contrast.

Recreation

To recreate this bug, checkout the staging branch and visit either the /monsters or /magic-items routes. Click the show filters button. Try using it in light mode, then try using it in dark mode.

Screenshot 2024-06-21 at 08 55 18 Screenshot 2024-06-21 at 08 55 28

The forms in the first and second image contain the same data, but in dark mode you cannot read it because the white text matches the background colour of the input element.

Solution

Add dark mode styles to the problematic form elements in the <MonsterKilterBox> and <MagicItemFilterBox>. We have used the TailwindCSS dark: selector to handle this elsewhere on the website.

@calumbell calumbell changed the title Bug: dark mode styles on <MonsterKilterBox> and <MagicItemFilterBox> Bug: dark mode styles on <MonsterFilterBox> and <MagicItemFilterBox> Jun 21, 2024
@calumbell
Copy link
Contributor Author

This issue was fixed when #518 was merged to staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant