Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: close modal menus on click-away or esc. key press #516

Closed
calumbell opened this issue Jun 20, 2024 · 0 comments · Fixed by #533
Closed

UI: close modal menus on click-away or esc. key press #516

calumbell opened this issue Jun 20, 2024 · 0 comments · Fixed by #533

Comments

@calumbell
Copy link
Contributor

Currently the modal menus for source selection and reporting an issue can only be closed usinig the buttons at the bottom of the menu. I feel that we could improve the user experience by implementing widely used modal menu design patterns where the menu can also be closed by:

  1. Clicking away from the modal menu (perhaps by adding an @click handler to the translucent shade that is put over the rest of the page)
  2. Pressing the ESCAPE key
Screenshot 2024-06-20 at 09 24 39

NB. These changes will be in addition to the current mechanisms for closing the menu. The buttons at the bottom of the modal will still work as they already do.

The <modal-dialogue> component is probably the best place to start, although the <sources-modal> and <report-issue> components might also need to be touched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant