Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search endpoint should be scoped to selected sources #408

Closed
eepMoody opened this issue Jun 20, 2023 · 1 comment · Fixed by #525
Closed

Search endpoint should be scoped to selected sources #408

eepMoody opened this issue Jun 20, 2023 · 1 comment · Fixed by #525
Assignees

Comments

@eepMoody
Copy link
Collaborator

eepMoody commented Jun 20, 2023

Want to explore a half-measure on this.

User feedback is that they expect this to honor their source selections. But If we hide it something silently because of a source selection it might be assumed it wasn't there.

I believe the correct resolution here is a hybrid solution, where we execute the search query against the entire dataset.
Then on the UI layer, we can hide the non-matching results behind a "view additional results from other sources" kind of button?

image image
@eepMoody eepMoody changed the title Examine whether the Search endpoint should be scoped to selected sources Search endpoint should be scoped to selected sources Jun 26, 2023
@calumbell calumbell self-assigned this Mar 10, 2024
@calumbell
Copy link
Contributor

I am taking a look at this today. Going to take some extra time to give the /search page a little refactor while I am here, it needs one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants