Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.diffplug.spotless:spotless-plugin-gradle from 6.21.0 to 6.25.0 #266

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions buildSrc/src/main/kotlin/RemotePublishing.kt
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ private object Pgp {
}

object ProtoktProjectInfo {
const val name = "Protokt"
const val url = "https://github.com/open-toast/protokt"
const val description = "Protobuf compiler and runtime for Kotlin"
const val NAME = "Protokt"
const val URL = "https://github.com/open-toast/protokt"
const val DESCRIPTION = "Protobuf compiler and runtime for Kotlin"
}

fun Project.isRelease() = !version.toString().endsWith("-SNAPSHOT")
Expand All @@ -64,10 +64,10 @@ fun Project.enablePublishing(defaultJars: Boolean = true) {

configure<MavenPublishBaseExtension> {
pom {
name.set(ProtoktProjectInfo.name)
description.set(ProtoktProjectInfo.description)
url.set(ProtoktProjectInfo.url)
scm { url.set(ProtoktProjectInfo.url) }
name.set(ProtoktProjectInfo.NAME)
description.set(ProtoktProjectInfo.DESCRIPTION)
url.set(ProtoktProjectInfo.URL)
scm { url.set(ProtoktProjectInfo.URL) }
licenses {
license {
name.set("The Apache License, Version 2.0")
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ gummyBears = "0.8.0"
java = "11"
kotlin = "1.9.23"
pluginPublish = "1.2.1"
spotless = "6.21.0"
spotless = "6.25.0"

# benchmarks
datasets = "0.1.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ private class MessageGenerator(

fun formatDoc(lines: List<String>) =
CodeBlock.of(
"%L", // escape the entire comment block
// escape the entire comment block
"%L",
lines.joinToString(" ") {
if (it.isBlank()) {
"\n\n"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ internal fun serialize(
interceptValueAccess(
f,
ctx,
if (f.repeated) { CodeBlock.of("it") } else { CodeBlock.of("%N", p) }
if (f.repeated) {
CodeBlock.of("it")
} else {
CodeBlock.of("%N", p)
}
)
} else {
interceptValueAccess(f, ctx, CodeBlock.of("%N.%N", o.fieldName, f.fieldName))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ abstract class AbstractProtoktCodegenTest {
listOf(
System.getenv("PROTOC_PATH") ?: "protoc",
"--plugin=protoc-gen-custom=$binGenerator",
"--custom_out=.", // ignored

// ignored
"--custom_out=.",

"-I$testDir",
"-I$extensionsProto",
"-I$includeProtos",
Expand Down
8 changes: 4 additions & 4 deletions protokt-gradle-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ plugins {
}

gradlePlugin {
website.set(ProtoktProjectInfo.url)
vcsUrl.set(ProtoktProjectInfo.url)
website.set(ProtoktProjectInfo.URL)
vcsUrl.set(ProtoktProjectInfo.URL)

plugins {
create("protokt") {
id = "com.toasttab.protokt"
implementationClass = "protokt.v1.gradle.ProtoktPlugin"
displayName = ProtoktProjectInfo.name
description = ProtoktProjectInfo.description
displayName = ProtoktProjectInfo.NAME
description = ProtoktProjectInfo.DESCRIPTION
tags.set(listOf("protobuf", "kotlin"))
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ external interface ServerWritableStream<ReqT, RespT> : ServerSurfaceCall, Object

@Beta
external interface ObjectWritable<T> : Writable {
@Suppress("ktlint:standard:function-naming")
fun _write(chunk: T, encoding: String, callback: Any)
fun write(chunk: T, callback: Any?): Boolean
fun write(chunk: T, encoding: Any?, callback: Any?): Boolean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ data class ProcessOutput(
}

enum class Src {
OUT, ERR
OUT,
ERR
}
}