Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve conformance test failure reporting #218

Merged
merged 3 commits into from
Jan 7, 2024
Merged

improve conformance test failure reporting #218

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a83eb84
improve conformance test failure reporting
andrewparmet Jan 6, 2024
666b41e
spurious pass
andrewparmet Jan 6, 2024
945bc4f
better
andrewparmet Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions testing/conformance/runner/src/test/kotlin/protokt/v1/conformance/ConformanceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,18 @@

package protokt.v1.conformance

import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.fail
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.MethodSource
import org.junit.jupiter.params.provider.EnumSource
import protokt.v1.testing.ProcessOutput
import protokt.v1.testing.projectRoot
import protokt.v1.testing.runCommand
import java.io.File
import java.nio.file.Path
import kotlin.io.path.deleteIfExists
import kotlin.io.path.exists
import kotlin.io.path.readText

class ConformanceTest {
enum class ConformanceRunner(
Expand All @@ -37,39 +41,38 @@ class ConformanceTest {
override fun driver() =
jsConformanceDriver(project)

override fun handle(t: Throwable) {
override fun onFailure() {
val stderr = jsStderrLog(project).toFile()
if (stderr.exists()) {
fail("test failed; stderr:\n" + stderr.readText())
} else {
throw t
if (stderr.exists() && stderr.readText().isNotEmpty()) {
println("stderr:\n" + stderr.readText())
}
}
}, // https://github.com/pinterest/ktlint/issues/1933
;

abstract fun driver(): Path

open fun handle(t: Throwable) {
throw t
}
open fun onFailure() = Unit
}

companion object {
@JvmStatic
fun runners() =
ConformanceRunner.entries
@BeforeEach
fun deleteFailingTests() {
failingTests.deleteIfExists()
}

@ParameterizedTest
@MethodSource("runners")
@EnumSource
fun `run conformance tests`(runner: ConformanceRunner) {
try {
command(runner)
.runCommand(projectRoot.toPath(), libPathOverride)
.orFail("Conformance tests failed", ProcessOutput.Src.ERR)
} catch (t: Throwable) {
runner.handle(t)
if (failingTests.exists()) {
println("Failing tests:\n" + failingTests.readText())
}
runner.onFailure()
throw t
}

println("Conformance tests passed")
Expand Down Expand Up @@ -100,6 +103,9 @@ private fun jsConformanceDriver(project: String) =
private fun jsStderrLog(project: String) =
Path.of(File(projectRoot.parentFile, project).absolutePath, "build", "conformance-run")

private val failingTests =
Path.of(projectRoot.absolutePath, "failing_tests.txt")

private fun failureList(project: String) =
"--failure_list ../$project/failure_list_kt.txt"

Expand Down