fix tags in codegen for large field numbers #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewparmet
commented
Jan 4, 2024
| message TestMessageWithDummy { | ||
| // This field is only here for triggering copy-on-write; it's not intended to | ||
| // be serialized. | ||
| bool dummy = 536870911; |
There was a problem hiding this comment.
This field breaks generated code. The rest of this file will be used to test the implementation of conversion to DynamicMessage.
ogolberg
reviewed
Feb 6, 2024
| @@ -595,7 +595,7 @@ public abstract interface class protokt/v1/KtMessageDeserializer { | |||
| public abstract fun readSInt32 ()I | |||
| public abstract fun readSInt64 ()J | |||
| public abstract fun readString ()Ljava/lang/String; | |||
| public abstract fun readTag ()I | |||
| public abstract fun readTag-pVg5ArA ()I | |||
There was a problem hiding this comment.
UInt nonsense.
There was a problem hiding this comment.
is this ABI going to be stable?
There was a problem hiding this comment.
I don't know. We already do this below - can we merge and revisit pre-1.0?
ogolberg
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They need to be unsigned in order to be literals.