-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement a converter to dynamic message #212
Merged
andrewparmet
merged 44 commits into
open-toast:main
from
andrewparmet:implement-converter-to-dynamic-message
May 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
2dd4541
implement a converter to dynamic message
andrewparmet dd96e8e
api dump
andrewparmet 72fbb9f
fix
andrewparmet da3ff2e
internal
andrewparmet 58b1d4c
reorganize shared but unpublished code
andrewparmet e28dd17
lint
andrewparmet 3659cb2
move over what is needed to infer protobuf type names
andrewparmet cd757ca
map value well known wrapper types do not work correctly
andrewparmet 21d9534
maps work
andrewparmet 283d20d
compilation
andrewparmet eca1983
more tests
andrewparmet 8e96790
api dump
andrewparmet f980afa
fix field presence lookup
andrewparmet 1036d0e
api dump
andrewparmet b2b0e1a
more api cleanup
andrewparmet 786ee1d
fix map wrapper types
andrewparmet 9d426aa
some cleanup
andrewparmet 5f6a280
mostly clean up map wrapper types
andrewparmet 3689bc8
isolate more and get tests passing
andrewparmet c783115
fix
andrewparmet 437909a
fix tags in codegen for large field numbers
andrewparmet d1a4417
api dump
andrewparmet deddc2d
Merge branch 'fix-tags-for-large-numbers' into implement-converter-to…
andrewparmet d357e38
change strategy for sharing potentially unpublished code
andrewparmet e2e0379
lint
andrewparmet c679e4f
Merge branch 'change-strategy-for-common-unpublished-code' into imple…
andrewparmet 33206b3
fix map wrapper types for well known wrappers
andrewparmet dbcd52c
Merge branch 'fix-map-wrapper-types' into implement-converter-to-dyna…
andrewparmet ed9c87b
remove guava
andrewparmet 294fb53
rm guava
andrewparmet 3af2204
rm line
andrewparmet d150db2
reflect need not be compatible with android
andrewparmet 0e82a08
turns out this line was needed
andrewparmet 301a9e2
Update build.gradle.kts
andrewparmet d50dd74
Merge branch 'main' into implement-converter-to-dynamic-message
andrewparmet af1af55
Update FieldTypeExt.kt
andrewparmet a171c1e
Merge branch 'main' into implement-converter-to-dynamic-message
andrewparmet ad92a9f
no data objects
andrewparmet ae1c609
don't allow conversion of null
andrewparmet dc621f5
Merge branch 'main' into implement-converter-to-dynamic-message
andrewparmet 27ff3cc
classpath scan only in tests
andrewparmet 5eaae73
apidump
andrewparmet c7e643e
update readme
andrewparmet bc8cea8
space
andrewparmet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
implement a converter to dynamic message
- Loading branch information
commit 2dd454150e9c34915e2365360dd0890c3c32bbd6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
/* | ||
* Copyright (c) 2023 Toast, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* http:https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
import com.google.protobuf.gradle.proto | ||
|
||
/* | ||
* Copyright (c) 2023 Toast, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* http:https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
plugins { | ||
id("protokt.multiplatform-conventions") | ||
} | ||
|
||
localProtokt(false) | ||
enablePublishing() | ||
compatibleWithAndroid() | ||
trackKotlinApiCompatibility() | ||
|
||
kotlin { | ||
sourceSets { | ||
val jvmMain by getting { | ||
dependencies { | ||
api(project(":protokt-core")) | ||
api(libs.protobuf.java) | ||
|
||
implementation(kotlin("reflect")) | ||
implementation(libs.guava) | ||
implementation(libs.classgraph) | ||
} | ||
} | ||
} | ||
} | ||
|
||
tasks.withType<JavaCompile> { enabled = true } | ||
|
||
sourceSets { | ||
main { | ||
proto { | ||
srcDir("../extensions/protokt-extensions-lite/src/main/proto") | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was removed a few PRs ago so it's dead code