Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Prepare v1.25.0 release #878

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Apr 3, 2024

Changes

  • Updates spec version from 1.26 to 1.31 (hence all the spec link changes)
  • Merges auto and manual changelogs

Merge requirement checklist

@lmolkova lmolkova requested review from a team April 3, 2024 21:46
@lmolkova lmolkova requested a review from a team April 3, 2024 21:46
@jack-berg
Copy link
Member

If you're interested, I can run semantic-conventions-java against this branch and spot check it for any issues. Don't have time today, but can do it tomorrow.

@lmolkova
Copy link
Contributor Author

lmolkova commented Apr 4, 2024

If you're interested, I can run semantic-conventions-java against this branch and spot check it for any issues. Don't have time today, but can do it tomorrow.

@jack-berg that'd be great, thanks!

I run the new compat-check tool and here's the list of breaking changes I see.
(The tool will be part of CI after this release and we'll not allow them anymore).

$ docker run --rm -v c:/repo/semantic-conventions/model:/source -v  c/repo/semantic-conventions/docs:/spec  otel/semconvgen:0.24.0 -f /source --continue-on-validation-errors compatibility --previous-version 1.24.0

Found 8 compatibility issues:
        enum attribute member 'messaging.system.azure_eventgrid' was removed
        enum attribute member 'messaging.system.azure_eventhubs' was removed
        enum attribute member 'messaging.system.azure_servicebus' was removed
        metric 'http.client.request.time_in_queue' was removed
        metric 'messaging.deliver.duration' was removed
        metric 'messaging.deliver.messages' was removed
        metric 'system.processes.count' was removed
        metric 'system.processes.created' was removed

In theory we can fix them, but I believe no one (including Java) generates metrics yet, so I'd rather not deprecate them this last time.

I'd also let messaging.system.azure_ die in silence because they were never supported by Azure SDK instrumentations or any other instrumentation I'm aware of.
If you feel strongly about keeping them, I could live with them being deprecated.

Let me know if you see any other incompatibilities or want to fix these ones.

@jack-berg
Copy link
Member

Here's a draft of what the changes look like in semantic-conventions-java: open-telemetry/semantic-conventions-java#61

Looks good to me!

@lmolkova lmolkova merged commit f1be151 into open-telemetry:main Apr 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants