Change http.request.body.size
and http.response.body.size
attributes from recommended to opt-in
#460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #456
Changes
There are a few concerns with
http.request.body.size
andhttp.response.body.size
:Content-Length
header which can already be captured ashttp.request.header.content-length
andhttp.response.header.content-length
Content-Length
is not always available, and actual bytes read could be different anyways if the request/response was cancelled.This PR does two things:
experimental
, along with a comment not to mark them stable when we mark the other HTTP attributes as stable next weekI will send a separate PR to propose changes to the definition of these attributes based on the other concerns above.
Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.