Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change http.request.body.size and http.response.body.size attributes from recommended to opt-in #460

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

trask
Copy link
Member

@trask trask commented Oct 27, 2023

Fixes #456

Changes

There are a few concerns with http.request.body.size and http.response.body.size:

  • They are not useful enough to justify their current "Recommended" requirement level
  • They are defined in terms of the Content-Length header which can already be captured as http.request.header.content-length and http.response.header.content-length
  • They should potentially be defined in terms of actual bytes read, since Content-Length is not always available, and actual bytes read could be different anyways if the request/response was cancelled.

This PR does two things:

  • Removes them from HTTP semconv (effectively making them opt-in)
  • Explicitly marks them as experimental, along with a comment not to mark them stable when we mark the other HTTP attributes as stable next week

I will send a separate PR to propose changes to the definition of these attributes based on the other concerns above.

Merge requirement checklist

@trask trask requested review from a team as code owners October 27, 2023 20:25
@trask trask force-pushed the remove-body-size-attributes branch from 80a2729 to 98c964e Compare October 27, 2023 20:26
model/registry/deprecated/http.yaml Outdated Show resolved Hide resolved
model/registry/deprecated/http.yaml Outdated Show resolved Hide resolved
model/trace/http.yaml Show resolved Hide resolved
@AlexanderWert
Copy link
Member

@trask I think you need to regenrate the tables

@pyohannes
Copy link
Contributor

I guess we should then consider doing the same for messaging (messaging.message.body.size and messaging.message.envelope.size) and RPC (message.compressed_size and message.uncompressed_size)?

@trask
Copy link
Member Author

trask commented Oct 30, 2023

I guess we should then consider doing the same for messaging (messaging.message.body.size and messaging.message.envelope.size) and RPC (message.compressed_size and message.uncompressed_size)?

I opened #474 to discuss/track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Are http.(request|response).body.size worth being recommended on HTTP spans (vs opt-in)?
7 participants