Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clarity to java sdk config descriptions around endpoints #4748

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

jaydeluca
Copy link
Member

Related to #4611

Clarifies that the OTLP endpoint refers to the address of a collector

@jaydeluca jaydeluca requested review from a team as code owners June 25, 2024 21:56
@jaydeluca jaydeluca changed the title add clarity to java sdk config descriptions around endpoints Add clarity to java sdk config descriptions around endpoints Jun 25, 2024
@svrnm svrnm added the sig-approval-missing Co-owning SIG didn't provide an approval label Jun 27, 2024
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
@svrnm svrnm removed the sig-approval-missing Co-owning SIG didn't provide an approval label Jun 28, 2024
@svrnm svrnm merged commit cc75ecc into open-telemetry:main Jun 28, 2024
16 checks passed
@svrnm
Copy link
Member

svrnm commented Jun 28, 2024

Thank you @jaydeluca for your continuous contributions, this is highly appreciated! If you want to (and I am happy to support you!) please go ahead an become an established member, you have plenty of contributions for that!

cc @open-telemetry/java-instrumentation-approvers @open-telemetry/docs-approvers

@jaydeluca
Copy link
Member Author

@svrnm thank you! it has been a goal of mine to become a member but I wasn't sure at what point it was appropriate to request sponsorship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants