Update semconv to 1.21.0, PART 2 - HTTP #9372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Sep 3, 2023
| @@ -64,7 +64,7 @@ private static <T> void addKey( | |||
| @SuppressWarnings("unchecked") | |||
| public static <T> AttributeKey<T> getAttributeKey(AttributeKey<T> oldKey) { | |||
| if (SemconvStability.emitStableHttpSemconv()) { | |||
| return (AttributeKey<T>) oldToNewMap.getOrDefault(oldKey, oldKey); | |||
| return (AttributeKey<T>) oldToNewMap.get(oldKey); | |||
mateuszrzeszutek
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting #9370 this up into smaller pieces for review. Once the parts are approved, I will merge them into a single PR, with one commit per part, and send any additional final commits if needed to make CI happy.I think this PR can stand alone and pass CI and be merged independently from #9370.