Implement new stable client semantic conventions #8704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+240
to
+241
| // TODO: client.port will be implemented in a future PR | ||
| return null; |
There was a problem hiding this comment.
I'll implement the client.port attribute in a separate PR - probably after the release, I think I'll refactor the FallbackNamePortGetter util a bit to avoid double parsing (as much as possible)
laurit
reviewed
Jun 13, 2023
| } | ||
| } | ||
| if (emitOldHttpAttributes) { | ||
| internalSet(attributes, SemanticAttributes.HTTP_CLIENT_IP, clientAddress); |
There was a problem hiding this comment.
I think here clientAddress doesn't have to be an ip, would that be a problem?
There was a problem hiding this comment.
In practice, no - right now the only place that can invoke this code branch is the HttpServerAttributesExtractor, nothing else in our codebase emits the client address.
laurit
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.