New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky CacheProviderTest #8684

Merged

laurit merged 1 commit into open-telemetry:main from laurit:flaky-test

Jun 11, 2023

Contributor

laurit commented Jun 9, 2023

https://ge.opentelemetry.io/s/jliv6liik57by/tests/:javaagent-tooling:test/io.opentelemetry.javaagent.tooling.CacheProviderTest/key%20different%20ref%20equivalence?top-execution=1
I believe this could happen when class loader is collected before test ends. When loader is collected cache key equals returns false


Fix flaky CacheProviderTest

laurit requested a review from a team as a code owner

June 9, 2023 09:23

trask approved these changes

View reviewed changes

laurit merged commit 8cfacd5 into open-telemetry:main

44 checks passed

laurit deleted the flaky-test branch

June 11, 2023 06:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment