Snippet Injection Smoke Test #8655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ap/src/main/java/io/opentelemetry/javaagent/bootstrap/servlet/ExperimentalSnippetHolder.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jun 6, 2023
...ap/src/main/java/io/opentelemetry/javaagent/bootstrap/servlet/ExperimentalSnippetHolder.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Jun 7, 2023
...ap/src/main/java/io/opentelemetry/javaagent/bootstrap/servlet/ExperimentalSnippetHolder.java
Outdated
Show resolved
Hide resolved
…/io/opentelemetry/javaagent/bootstrap/servlet/ExperimentalSnippetHolder.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
trask
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smoke Test aiming at testing snippet injection which is developed in #7650 and #8569
The reason for adding the java arguments of setting snippet in the environment list instead of via environment setting in the single test is because that would not work.
Additionally explored the possibility of modifying the Dockerfile to allow different servers to accept JVM arguments. However, I encountered challenges with certain Dockerfiles that require modifications involving the addition of a jvm.options file, making it difficult to implement this change universally.
Considering that adding another jvm args would not impact other tests functionality, the snippet setting is added in the container env directly.