Fix http pipelining test on Netty 4.1 #8412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
May 4, 2023
trask
approved these changes
May 5, 2023
|
#2496 could probably be resolved by changing the channel attributes into queues. Request handler would push new context/request to the end of the queue and response handler would remove the first element of the queue. This should avoid new requests coming in overwriting context for the in progress request. Server instrumentation will also probably need similar queueing to work when response isn't written immediately after reading the request. You could read the requests, place them in a queue and write responses after all requests are read which would fail with current instrumentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.