More HTTP testing refactor prework #7630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another follow-up from #7616. This makes the test options class immutable and uses
@AutoValue
and@AutoValue.Builder
. As a result, a bunch of the configuration/setup code for these said options now flings around a builder instance. This isn't great, but I think it's an incremental improvement that can be seen in the@BeforeAll AbstractHttpClientTest.setupOptions()
method, where the immutable options are (finally) instantiated.