Fix NoClassDefFoundError happening when snakeyaml is used on a custom JRE #7598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Jan 18, 2023
.../jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/yaml/RuleParser.java
Outdated
Show resolved
Hide resolved
| @@ -417,19 +421,6 @@ void testEmptyTagFromParameter() { | |||
| runNegativeTest(yaml); | |||
| } | |||
|
|
|||
| @Test | |||
| void testEmptyPrefix() { | |||
There was a problem hiding this comment.
This test case no longer makes any sense with the new parser.
| Yaml yaml = new Yaml(new Constructor(JmxConfig.class)); | ||
| return yaml.load(is); | ||
| @SuppressWarnings("unchecked") | ||
| public JmxConfig loadConfig(InputStream is) { |
There was a problem hiding this comment.
I think that the whole JMX config parsing module needs some further refactoring -- we could simplify the code, remove mutability, and clearly separate parsing from converting the config to its "executable" form. Not in this PR though, let's not mix concerns.
trask
reviewed
Jan 18, 2023
There was a problem hiding this comment.
@PeterF778 if you have a chance, can you review these changes to the jmx-metrics module?
PeterF778
reviewed
Jan 19, 2023
...n/jmx-metrics/library/src/main/java/io/opentelemetry/instrumentation/jmx/yaml/JmxConfig.java
Outdated
Show resolved
Hide resolved
|
The changes look good. Thanks, @mateuszrzeszutek, for rewriting the JMX Metric Insight yaml parser to work with snakeyaml-engine. |
635ecfe
to
9c4d20a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7580