Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md for java 17 #7459

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Update CONTRIBUTING.md for java 17 #7459

merged 2 commits into from
Jan 3, 2023

Conversation

breedx-splk
Copy link
Contributor

Looks like building the new Spring instrumentation requires java 17+, right?

@breedx-splk breedx-splk requested a review from a team as a code owner December 21, 2022 18:57
theletterf
theletterf reviewed Dec 22, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
theletterf
theletterf approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nit!

@mateuszrzeszutek mateuszrzeszutek linked an issue Dec 28, 2022 that may be closed by this pull request
Project now requires Java 17+ to compile #7458
Closed
@breedx-splk @theletterf
Update CONTRIBUTING.md
b0ecb54 
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
trask
trask approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's probably some way to make byteBuddyJava gradle toolchain aware but it's beyond me 🤷‍♂️

@trask trask merged commit 4da5c1d into open-telemetry:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@theletterf theletterf theletterf approved these changes

@laurit laurit laurit approved these changes

@liangyuanpeng liangyuanpeng liangyuanpeng approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project now requires Java 17+ to compile
6 participants
@breedx-splk @trask @theletterf @laurit @liangyuanpeng @mateuszrzeszutek