Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump logback-classic from 1.2.11 to 1.4.4 in /examples/extension #7056

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 4, 2022

Bumps logback-classic from 1.2.11 to 1.4.4.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner November 4, 2022 21:46
@trask
Copy link
Member

trask commented Nov 5, 2022

@dependabot rebase

Bumps [logback-classic](https://github.com/qos-ch/logback) from 1.2.11 to 1.4.4.
- [Release notes](https://github.com/qos-ch/logback/releases)
- [Commits](qos-ch/logback@v_1.2.11...v_1.4.4)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-classic
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/examples/extension/ch.qos.logback-logback-classic-1.4.4 branch from 91035d1 to c1a3785 Compare November 5, 2022 01:43
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure since this module is probably still getting slf4j 1.x via transitive deps

@trask
Copy link
Member

trask commented Nov 8, 2022

I'm not sure since this module is probably still getting slf4j 1.x via transitive deps

Tests are compiled against slf4j 1.x, but they are run against slf4j 2.x + logback 1.4.4

@trask
Copy link
Member

trask commented Nov 9, 2022

@mateuszrzeszutek @laurit just in case you have any thoughts on this

@trask trask merged commit e293fe2 into main Nov 9, 2022
@trask trask deleted the dependabot/gradle/examples/extension/ch.qos.logback-logback-classic-1.4.4 branch November 9, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants