Enable PrivateConstructorForUtilityClass errorprone check #6427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Aug 9, 2022
Comment on lines
39
to
40
| @SuppressWarnings({"PrivateConstructorForUtilityClass", "unused"}) | ||
| public static class DemoServlet3Advice { |
There was a problem hiding this comment.
Maybe we could do
if (name.endsWith("Advice")) {
disable("PrivateConstructorForUtilityClass")
}instead of suppressing this in every advice class? WDYT?
There was a problem hiding this comment.
unfortunately this doesn't work (the gradle block is only resolved once, not per class name)
but this suppression on all of the advice classes is sufficiently horrendous, so I went ahead and added a custom OtelPrivateConstructorForUtilityClass check that ignores Advice classes
| @@ -54,4 +54,6 @@ static boolean isLocalRoot(Context parentContext) { | |||
| static Context store(Context context, Span span) { | |||
| return context.with(KEY, span); | |||
| } | |||
|
|
|||
| private LocalRootSpan() {} | |||
mateuszrzeszutek
approved these changes
Aug 10, 2022
laurit
approved these changes
Aug 10, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…etry#6427) * PrivateConstructorForUtilityClass * Advice * More advice * More * More advice * More * Spotless * Fix * Fix * Fix * A better solution * Revert * More * Fix * Spotless * Fix
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…etry#6427) * PrivateConstructorForUtilityClass * Advice * More advice * More * More advice * More * Spotless * Fix * Fix * Fix * A better solution * Revert * More * Fix * Spotless * Fix
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…etry#6427) * PrivateConstructorForUtilityClass * Advice * More advice * More * More advice * More * Spotless * Fix * Fix * Fix * A better solution * Revert * More * Fix * Spotless * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily motivated by having (mostly) same errorprone configuration/checks as the other Java repos.