Extract HTTP request & response content length from headers #6415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mateuszrzeszutek there is a slight catch here for apache http clients. The instrumentation flows are as follows:
Thus in case of all apache http clients response content length is coming fine because the one that comes is the one delivered to the user back but the request content length headers and attributes are missing because the one submitted by the user is not the actual one that goes in the request. |
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…emetry#6415) * Extract HTTP request & response content length from headers * remove unused method * fix camel tests * fix google http client tests * fix HttpUrlConnection tests * fix k8s and jaxrs tests * fix aws tests * actually fix aws tests 🤞 * fix elasticsearch tests * fix ratpack tests * fix spring webflux tests * fix vertx tests * fix reactor netty tests
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…emetry#6415) * Extract HTTP request & response content length from headers * remove unused method * fix camel tests * fix google http client tests * fix HttpUrlConnection tests * fix k8s and jaxrs tests * fix aws tests * actually fix aws tests 🤞 * fix elasticsearch tests * fix ratpack tests * fix spring webflux tests * fix vertx tests * fix reactor netty tests
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…emetry#6415) * Extract HTTP request & response content length from headers * remove unused method * fix camel tests * fix google http client tests * fix HttpUrlConnection tests * fix k8s and jaxrs tests * fix aws tests * actually fix aws tests 🤞 * fix elasticsearch tests * fix ratpack tests * fix spring webflux tests * fix vertx tests * fix reactor netty tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and deprecate the
requestContentLength()andresponseContentLength()methods in the getter interface. I figured that almost all instrumentations (except Armeria) get these from the headers anyway, so we might as well keep the API simple and remove them altogether.