Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename newInstrumenter() into buildInstrumenter() #6363

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

mateuszrzeszutek
Copy link
Member

All OTel API/SDK builders use build*() for the terminal operation name, I figured that we should follow that convention too.

@mateuszrzeszutek mateuszrzeszutek requested a review from a team July 22, 2022 13:06
@mateuszrzeszutek mateuszrzeszutek changed the title Rename newInstrumenter() into buildInstrumenter() Rename newInstrumenter() into buildInstrumenter() Jul 22, 2022
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 82b39b1 into open-telemetry:main Jul 25, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the rename-newInstrumenter branch July 26, 2022 04:26
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 23, 2022
…#6363)

* Rename newInstrumenter() into buildInstrumenter()

* spotless
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Oct 31, 2022
…#6363)

* Rename newInstrumenter() into buildInstrumenter()

* spotless
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this pull request Dec 4, 2022
…#6363)

* Rename newInstrumenter() into buildInstrumenter()

* spotless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants