Spring starter - Add api opentelemetry-sdk-extension-autoconfigure-spi #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A colleague was encountering this error when attempting to use
opentelemetry-spring-starter.I'm not 100% confident in this, but it looks like the starter includes the
spring:spring-boot-autoconfigureinstrumentation, which includes theOtelResourceAutoConfigurationclass from the stack trace. That class directly referencesResourceProvider, which is brought in fromopentelemetry-sdk-extension-autoconfigure-spibut viacompileOnly, so the user doesn't have it at runtime.The colleague was able to work around the error by including
opentelemetry-sdk-extension-autoconfigure-spiin their dependency list, but we don't include that in the docs and it seemed like it made sense to include it in the starter bundle.If adding the dep here isn't the right approach, I'm happy to pivot, just let me know.