add runtime metrics for buffer pool #6177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cuichen Li <[email protected]>
laurit
reviewed
Jun 16, 2022
.../java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/RuntimeMetricsInstaller.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Cuichen Li <[email protected]>
jack-berg
reviewed
Jun 17, 2022
| @@ -38,6 +39,7 @@ public void afterAgent(Config config, AutoConfiguredOpenTelemetrySdk unused) { | |||
| if (config.getBoolean( | |||
| "otel.instrumentation.runtime-metrics.experimental-metrics.enabled", false)) { | |||
| GarbageCollector.registerObservers(GlobalOpenTelemetry.get()); | |||
| BufferPools.registerObservers(GlobalOpenTelemetry.get()); | |||
There was a problem hiding this comment.
Our process for adding these has been to discuss in the metrics JVM SIG, and codify in the runtime semantic conventions.
Are you able to attend the JVM metrics SIG?
If not, we should invite the participants to have a discussion here.
There was a problem hiding this comment.
sorry, due to the time difference, i may not be able to attend the SIG meeting.
There was a problem hiding this comment.
i've requested JVM metrics folks to have a look at this PR
(also @cuichenli in case you didn't notice, the JVM metrics meetings are at alternating times to accommodate different timezones)
jack-berg
reviewed
Jun 17, 2022
| .buildWithCallback(callback(bufferBeans, BufferPoolMXBean::getMemoryUsed)); | ||
|
|
||
| meter | ||
| .upDownCounterBuilder("process.runtime.jvm.buffer.max") |
There was a problem hiding this comment.
Let's use limit per naming conventinos.
jack-berg
reviewed
Jun 17, 2022
|
|
||
| meter | ||
| .upDownCounterBuilder("process.runtime.jvm.buffer.count") | ||
| .setDescription("Total capacity of the buffers in this pool") |
There was a problem hiding this comment.
Suggested change
| .setDescription("Total capacity of the buffers in this pool") | |
| .setDescription("The number of buffers in the pool") |
See getCount
Signed-off-by: Cuichen Li <[email protected]>
Signed-off-by: Cuichen Li <[email protected]>
jack-berg
approved these changes
Jun 27, 2022
trask
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4876
Signed-off-by: Cuichen Li [email protected]