Fix a metrics API bridging issue #6034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ plugins { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compileOnly(project(":opentelemetry-api-shaded-for-instrumenting", configuration = "shadow")) | |||
| compileOnly(project(":opentelemetry-api-shaded-for-instrumenting", configuration = "v1_10")) | |||
There was a problem hiding this comment.
IntelliJ kept adding back the @Override annotation no matter how I configured it when this module was compiled against the latest version - I had to add some gradle voodoo to generate shaded 1.10 metrics api.
trask
approved these changes
May 16, 2022
| @@ -3,7 +3,7 @@ plugins { | |||
| } | |||
|
|
|||
| dependencies { | |||
| compileOnly(project(":opentelemetry-api-shaded-for-instrumenting", configuration = "shadow")) | |||
| compileOnly(project(":opentelemetry-api-shaded-for-instrumenting", configuration = "v1_10")) | |||
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that you can't close an observable instrument from the application side, we weren't bridging
close()methods before.