Add an SPI for customizing Config just before it's set #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
reviewed
May 12, 2022
|
Hmm, it probably would make sense -- we could add a |
mateuszrzeszutek
force-pushed
the
config-customizer
branch
from
22a43fb
to
3bc8054
Compare
trask
approved these changes
May 16, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…y#6010) * Add an SPI for customizing Config just before it's set * deprecate ConfigPropertySource in favor of ConfigCustomizer * errorprone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this might be a useful thing to have, e.g. when you want to set a property based on the value of some another property. I added it to javaagent-tooling initially, but we can move to to extension-api if we decide to support that in public API.