A hook in HelperInjector for static instrumentation #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzzle/src/main/java/io/opentelemetry/javaagent/tooling/HelperInjector.java
Outdated
Show resolved
Hide resolved
muzzle/src/main/java/io/opentelemetry/javaagent/tooling/HelperInjector.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Apr 22, 2022
trask
approved these changes
Apr 22, 2022
muzzle/src/main/java/io/opentelemetry/javaagent/tooling/StaticInstrumenterHook.java
Outdated
Show resolved
Hide resolved
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are working in the contrib repo on a distribution of the agent that is capable of static instrumentation, we need to add a hook in HelperInjector that provides access to additional classes created by the agent.
For more context, see this discussion and the static instrumentation issue