Spring-kafka single record instrumentation #5904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Apr 21, 2022
Comment on lines
-39
to
+40
| public static void onExit() { | ||
| KafkaClientsConsumerProcessTracing.enableWrapping(); | ||
| public static void onExit(@Advice.Enter boolean previousValue) { | ||
| KafkaClientsConsumerProcessTracing.setEnabled(previousValue); |
trask
pushed a commit
that referenced
this pull request
Apr 22, 2022
Co-authored-by: Mateusz Rzeszutek <[email protected]>
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That should fix Kafka telemetry for spring-kafka users, at least those using version >=2.7 -- earlier versions do not have the interceptor interfaces (or they're incomplete), so if we want to instrument them we'll have to modify private method code.
By the way -- I think #5826 might have introduced a regression; by disabling kafka-clients tracing in
KafkaMessageListenerContainer$ListenerConsumerALL tracing was disabled, including single record listeners. Users that were using spinrg-kafka >=2.7 with single record listeners would not get the consumer process telemetry this way <-- @open-telemetry/java-instrumentation-maintainers should we add this PR to the patch release too?