record exception in dubbo high version #5892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
reviewed
Apr 20, 2022
| @@ -63,7 +63,7 @@ public Result invoke(Invoker<?> invoker, Invocation invocation) { | |||
| throw e; | |||
| } | |||
| if (isSynchronous) { | |||
| instrumenter.end(context, request, result, null); | |||
| instrumenter.end(context, request, result, result.getException()); | |||
There was a problem hiding this comment.
should async case also use something like throwable != null ? throwable : result.getException()?
There was a problem hiding this comment.
this change is only for server side. the async case is for the client in dubbo. I check the code in brave too, it only use 'result.getException()' in sync case too.
laurit
approved these changes
Apr 20, 2022
trask
approved these changes
Apr 20, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in dubbo server side, it will not throw exception. instead it will put the exception in
Result, so we miss the exception in server side now