Update to OTel 1.13 #5799
Update to OTel 1.13 #5799
Conversation
| @@ -30,6 +32,11 @@ void reset() { | |||
| collectedRequests.clear(); | |||
| } | |||
|
|
|||
| @Override | |||
| public AggregationTemporality getAggregationTemporality(InstrumentType instrumentType) { | |||
There was a problem hiding this comment.
/cc @jack-berg Hopefully people will generally be able to use our metric exporters even in testing, but if for some reason someone has to implement this method they'll have absolutely no idea how to do so I think. I have a feeling defaulting to cumulative would have a net positive effect on confused users (it will also cause confusion, but my hypothesis is less so)
…nstrumentation into otel-1.13
| abstract class TomcatSmokeTest extends AppServerTest { | ||
|
|
||
| protected String getTargetImagePrefix() { | ||
| "ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-servlet-tomcat" | ||
| } | ||
|
|
||
| @Override | ||
| protected TargetWaitStrategy getWaitStrategy() { |
There was a problem hiding this comment.
I saw connection failures and thought it could be Armeria-related, but realized that the tests were running before the server started. I don't think there's anything in this PR that would slow down startup time but maybe there is? Or just at a borderline that I'm unluckily breaking
…nstrumentation into otel-1.13
| SdkMeterProvider.builder() | ||
| .registerMetricReader(metricReader) | ||
| .setMinimumCollectionInterval(Duration.ZERO) | ||
| .build(); | ||
| SdkMeterProvider.builder().registerMetricReader(metricReader).build(); |
| .hasInstrumentationLibraryInfo( | ||
| InstrumentationLibraryInfo.create("test", null)) | ||
| .hasInstrumentationScopeInfo(InstrumentationScopeInfo.create("test")) |
There was a problem hiding this comment.
well, that's something better about Scope, it's shorter then Library 😄
| protected TargetWaitStrategy getWaitStrategy() { | ||
| return new TargetWaitStrategy.Log(Duration.ofMinutes(1), ".*Listening on.*") | ||
| } |
There was a problem hiding this comment.
Just want to confirm if it's anything to be concerned about (file an issue about)? I've never seen startup time failures until this PR I think
There was a problem hiding this comment.
I think this is the correct thing to do. It is hard to explain why these are suddenly needed but for example SpringBootSmokeTest already had it while it was added to SpringBootWithSamplingSmokeTest in this pr. So might as well argue that it was strange that SpringBootWithSamplingSmokeTest worked before.
* Update to OTel 1.13 * Fix test * Foo * Fix app server test and start yak shaving * Yak * Yak * groovy fail * Yak * GROOVY * yak farm
No description provided.