Rename view and controller suppression config properties #5747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Apr 4, 2022
Comment on lines
162
to
169
| /** | ||
| * Disables the {@link Instrumenter} - it will not generate any telemetry. | ||
| * | ||
| * <p>Equivalent to calling {@code .setEnabled(false)}. | ||
| */ | ||
| public InstrumenterBuilder<REQUEST, RESPONSE> disable() { | ||
| return setEnabled(false); | ||
| } |
There was a problem hiding this comment.
this looks like it's only called from a test, do you think it will be more generally useful in the future?
There was a problem hiding this comment.
Hmm, I included it because I thought that it could be a good idea to have a method that explicitly disables the instrumenter, but on the second thought, it's not that useful -- you'd probably want to disable the instrumenter based on some configuration property, in which case you'd almost always call .setEnabled().
I'll remove it, we probably don't need it in the first stable release.
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…try#5747) * Rename view and controller suppression config properties * code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that they use the
...something-telemetry.enablednaming scheme.Also, I changed the Instrumenter API and added the
setEnabled()method so that you don't have to negate the boolean value before passing it to the builder.