Remove duplicate gradle build cache #5522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
remove-duplicate-gradle-caching
branch
4 times, most recently
from
07f0ec0
to
3828e1a
Compare
trask
force-pushed
the
remove-duplicate-gradle-caching
branch
from
3828e1a
to
5fcb0ce
Compare
anuraaga
approved these changes
Mar 19, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we use gradle enterprise for build cache, I think we can save space on github action cache.
@anuraaga I looked into using
actions/cacheto have more control over cache keys as we discussed last week, butactions/cachehas no support for read-only mode in PRs which could make our problem worse. I still want to revisit, but I'd like to confirm with this PR that we aren't really using build cache from github actions anyways.