Apply conventions to custom-checks project #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
force-pushed
the
custom-checks-conventions
branch
3 times, most recently
from
0025b59
to
42c414a
Compare
anuraaga
force-pushed
the
custom-checks-conventions
branch
from
42c414a
to
b3fda17
Compare
trask
approved these changes
Feb 4, 2022
| @@ -60,8 +62,9 @@ private static boolean isInternal(VisitorState state) { | |||
| if (packageTree == null) { | |||
| return false; | |||
| } | |||
| String packageName = packageTree.getPackageName().toString(); | |||
| return INTERNAL_PACKAGE_PATTERN.matcher(packageName).find() | |||
| String packageName = state.getSourceForNode(packageTree.getPackageName()); | |||
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom-checks project is missing important conventions such as the
releaseversion of the artifact, so currently the project doesn't build when running the build with a newer version of Java than 11.Luckily it's not too tedious to solve the circular reference.