Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expected server span name for null route should be HTTP GET #5197

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Expected server span name for null route should be HTTP GET #5197

merged 1 commit into from
Jan 22, 2022

Conversation

mateuszrzeszutek
Copy link
Member

Another one of HttpServerTest simplifications from #442

@mateuszrzeszutek mateuszrzeszutek requested a review from a team January 21, 2022 11:16
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Jan 21, 2022
Closed
@mateuszrzeszutek mateuszrzeszutek force-pushed the HttpServerTest-expectedServerSpanName branch from a153bfb to 0a456cf Compare January 21, 2022 16:37
trask
trask approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@trask trask merged commit 9381d5a into open-telemetry:main Jan 22, 2022
@mateuszrzeszutek mateuszrzeszutek deleted the HttpServerTest-expectedServerSpanName branch January 24, 2022 07:33
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@RashmiRam
Expected server span name for null route should be HTTP GET (open-tel…
088f0cc 
…emetry#5197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszrzeszutek @trask