Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out NetServerAttributesGetter #5194

Merged
merged 4 commits into from
Jan 22, 2022

Conversation

breedx-splk
Copy link
Contributor

Continuing our series on favoring composition over inheritance. This is a follow-up from #5030, but geared at the server attributes.

@breedx-splk breedx-splk requested a review from a team January 20, 2022 23:38
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that NetServerAttributesGetter is only parameterized by REQUEST

breedx-splk and others added 2 commits January 21, 2022 08:54
…tion/api/instrumenter/net/NetServerAttributesGetter.java

Co-authored-by: Mateusz Rzeszutek <[email protected]>
@trask
Copy link
Member

trask commented Jan 21, 2022

@breedx-splk looks like needs another spotlessApply then will merge

@trask trask merged commit fe8a132 into open-telemetry:main Jan 22, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* factor out NetServerAttributesGetter and favor composition over inheritance.

* Update instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/net/NetServerAttributesGetter.java

Co-authored-by: Mateusz Rzeszutek <[email protected]>

* errorprone and spotless

* spotless

Co-authored-by: Mateusz Rzeszutek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants