Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce top level instrumentation directories #4965

Merged
merged 5 commits into from
Dec 22, 2021
Merged

Reduce top level instrumentation directories #4965

merged 5 commits into from
Dec 22, 2021

Conversation

trask
Copy link
Member

@trask trask commented Dec 22, 2021

The easy/uncontroversial parts of #4952

  • move akka-actor-2.5, akka-actor-fork-join-2.5 and akka-http-10.0 under common akka directory
  • move dropwizard-testing and dropwizard-views-0.7 under common dropwizard directory
  • move kafka-clients and kafka-streams-0.11 under common kafka directory
  • move reactor-3.1 and reactor-netty under common reactor directory
    • and rename existing reactor-3.1 to reactor-core-3.1
  • move vertx-http-client, vertx-reactive-3.5 and vertx-web-3.0 under common vertx directory

@trask trask merged commit 6884d66 into open-telemetry:main Dec 22, 2021
@trask trask deleted the reduce-top-level-instrumentation-directories branch December 22, 2021 18:16
@trask trask mentioned this pull request Dec 22, 2021
Merged
@trask trask mentioned this pull request Jan 29, 2022
Closed
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@trask @RashmiRam
Reduce top level instrumentation directories (open-telemetry#4965)
59a3ef8 
* akka

* dropwizard

* kafka

* reactor

* vertx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@laurit laurit laurit approved these changes

@iNikem iNikem iNikem approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@mateuszrzeszutek mateuszrzeszutek Awaiting requested review from mateuszrzeszutek

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trask @anuraaga @laurit @iNikem