Minor log4j instrumentation updates #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
trask
commented
Dec 18, 2021
| @@ -32,7 +32,6 @@ | |||
| * <li>Thread id - {@link LogEvent#getThreadId()} | |||
| * <li>Thread priority - {@link LogEvent#getThreadPriority()} | |||
| * <li>Thread priority - {@link LogEvent#getThreadPriority()} | |||
| * <li>Thrown details (stack trace, class name) - {@link LogEvent#getThrown()} | |||
There was a problem hiding this comment.
removing from list because this is already captured below
trask
commented
Dec 18, 2021
Comment on lines
81
to
+82
| case TRACE: | ||
| return Severity.TRACE2; | ||
| return Severity.TRACE; |
There was a problem hiding this comment.
@jack-berg want to confirm this change with you
anuraaga
approved these changes
Dec 20, 2021
|
going ahead and merging b/c worried about conflicts with all my inflight logging PRs 😭, but please feel free to still review/comment on this PR and I will resolve in follow-up(s) |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Minor log4j instrumentation updates * Remove duplicate line * Use semantic attributes for exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.