Simplify the thread-safe handling of the globalLogEmitterProvider #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh, yes, this is much simpler!
this behavior could be better, e.g. in cases where you aren't able to set the global early enough, though I'm not sure how it will work with autoconfiguration (though to be honest I don't know how any of this will work with autoconfiguration yet)
the NoOp impl is package-private, so I don't think this is an issue |
breedx-splk
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
mateuszrzeszutek
approved these changes
Dec 21, 2021
...rc/test/java/io/opentelemetry/instrumentation/api/appender/GlobalLogEmitterProviderTest.java
Outdated
Show resolved
Hide resolved
…strumentation/api/appender/GlobalLogEmitterProviderTest.java Co-authored-by: Mateusz Rzeszutek <[email protected]>
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
…en-telemetry#4936) * Simplify the thread-safe handling of the globalLogEmitterProvider * Update instrumentation-api-appender/src/test/java/io/opentelemetry/instrumentation/api/appender/GlobalLogEmitterProviderTest.java Co-authored-by: Mateusz Rzeszutek <[email protected]> Co-authored-by: Mateusz Rzeszutek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on some comments in #4917
@trask This should show what I was getting at with my comments before. There are two slight semantic differences with this approach: 1) calling
get()beforeset()is ok, you just get the NoOp impl. 2) callingset()multiple times with the NoOp impl is fine. I think this is acceptable, but others could differ.I completely understand if we don't want to do this because it's inconsistent with the others.