Use ratpack 1.4.1 for testing #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
approved these changes
Nov 30, 2021
mateuszrzeszutek
approved these changes
Nov 30, 2021
trask
reviewed
Nov 30, 2021
| @@ -92,7 +92,10 @@ abstract class NettyAlignmentRule : ComponentMetadataRule { | |||
| dependencies { | |||
| add(dependencyManagementConf.name, platform(project(":dependencyManagement"))) | |||
|
|
|||
| components.all<NettyAlignmentRule>() | |||
| // ratpack tests don't work correctly with 4.1.65.Final | |||
There was a problem hiding this comment.
The problem is that besides the fix that hopefully gets rid of the flakiness there is another change that breaks some tests when run with netty 4.1.65. These tests pass when run with the netty version that ratpack depends on. All tests in RatpackPooledHttpClientTest fail, from other http client tests only highConcurrencyOnSingleConnection fails, there are also failures under library tests.
...main/java/io/opentelemetry/instrumentation/ratpack/client/AbstractRatpackHttpClientTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Trask Stalnaker <[email protected]>
trask
approved these changes
Nov 30, 2021
Comment on lines
+32
to
+46
| // to allow all tests to pass we need to choose a specific netty version | ||
| if (!(findProperty("testLatestDeps") as Boolean)) { | ||
| configurations.configureEach { | ||
| if (!name.contains("muzzle")) { | ||
| resolutionStrategy { | ||
| eachDependency { | ||
| // specifying a fixed version for all libraries with io.netty group | ||
| if (requested.group == "io.netty") { | ||
| useVersion("4.1.31.Final") | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
trask
added a commit
that referenced
this pull request
Dec 1, 2021
* Use ratpack 1.4.1 for testing * don't force netty version in ratpack tests * spotless * Apply suggestions from code review Co-authored-by: Trask Stalnaker <[email protected]> * enable https test Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]>
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Use ratpack 1.4.1 for testing * don't force netty version in ratpack tests * spotless * Apply suggestions from code review Co-authored-by: Trask Stalnaker <[email protected]> * enable https test Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4736
Resolves #4618
I believe that the flakiness of ratpack tests is caused by a bug in ratpack that was fixed in this commit ratpack/ratpack@dde536a
Basically due to using wrong type of queue some threads will end in a busy loop inside queue implementation because internal state of the queue has been corrupted. Here is a sample of such stuck thread