Fix spring-integration context leak #4673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Nov 19, 2021
Comment on lines
+47
to
+53
| // | ||
| // there's an option for this class to implement VetoCapableInterceptor and prevent itself | ||
| // from being registered if it's already registered, but the VetoCapableInterceptor interface | ||
| // broke backwards compatibility in 5.2.0, and the version prior to 5.2.0 takes a parameter | ||
| // of type ChannelInterceptorAware which doesn't exist after 5.2.0, and while it's possible to | ||
| // implement both at the same time (since we compile using 4.1.0), muzzle doesn't like the | ||
| // missing class type when running testLatestDeps |
There was a problem hiding this comment.
I can remove this part if it seems too much, I just didn't want others to go down this road, at least without knowing the pitfalls ahead of time
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
approved these changes
Nov 19, 2021
laurit
approved these changes
Nov 19, 2021
iNikem
approved these changes
Nov 19, 2021
Comment on lines
+47
to
+53
| // | ||
| // there's an option for this class to implement VetoCapableInterceptor and prevent itself | ||
| // from being registered if it's already registered, but the VetoCapableInterceptor interface | ||
| // broke backwards compatibility in 5.2.0, and the version prior to 5.2.0 takes a parameter | ||
| // of type ChannelInterceptorAware which doesn't exist after 5.2.0, and while it's possible to | ||
| // implement both at the same time (since we compile using 4.1.0), muzzle doesn't like the | ||
| // missing class type when running testLatestDeps |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.