Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert TextMapSetters and TextMapGetters to enums #4522

Merged
merged 4 commits into from
Nov 8, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into enums
  • Loading branch information
iNikem committed Nov 4, 2021
commit f2ffdb79ed84936c0af25d4d16e1673e04a0831d
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,8 @@ public RatpackTracing build() {
.addAttributesExtractor(httpAttributes)
.addAttributesExtractors(additionalExtractors)
.addRequestMetrics(HttpServerMetrics.get())
.newServerInstrumenter(new RatpackGetter());
.newServerInstrumenter(RatpackGetter.INSTANCE);

builder.setSpanStatusExtractor(HttpSpanStatusExtractor.create(httpAttributes));
builder.addAttributesExtractor(netAttributes);
builder.addAttributesExtractor(httpAttributes);
builder.addAttributesExtractors(additionalExtractors);

return new RatpackTracing(builder.newServerInstrumenter(RatpackGetter.INSTANCE));
return new RatpackTracing(instrumenter);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public RestletTracing build() {
.addAttributesExtractor(httpAttributesExtractor)
.addAttributesExtractor(netAttributesExtractor)
.addAttributesExtractors(additionalExtractors)
.addRequestMetrics(HttpServerMetrics.get())
.newServerInstrumenter(RestletHeadersGetter.INSTANCE);

return new RestletTracing(instrumenter);
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.