Review "writing-instrumentation-module.md" #4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A peer review of "writing-instrumentation-module" for language and style, as requested by @mateuszrzeszutek .
theletterf
commented
Oct 26, 2021
theletterf
commented
Oct 26, 2021
theletterf
commented
Oct 26, 2021
theletterf
commented
Oct 26, 2021
theletterf
commented
Oct 26, 2021
theletterf
commented
Oct 26, 2021
theletterf
commented
Oct 26, 2021
theletterf
commented
Oct 26, 2021
theletterf
commented
Oct 26, 2021
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
|
Only thing missing is the headings, @mateuszrzeszutek — but we can choose to postpone. |
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
|
thx @theletterf! |
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Review "writing-instrumentation-module.md" A peer review of "writing-instrumentation-module" for language and style, as requested by @mateuszrzeszutek . * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md * Update docs/contributing/writing-instrumentation-module.md * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update writing-instrumentation-module.md * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Update docs/contributing/writing-instrumentation-module.md Co-authored-by: Mateusz Rzeszutek <[email protected]> * Apply suggestions from code review Co-authored-by: Mateusz Rzeszutek <[email protected]> * Spotless Co-authored-by: Mateusz Rzeszutek <[email protected]> Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A peer review of "writing-instrumentation-module" for language and style, as requested by @mateuszrzeszutek .