Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish javaagent bootstrap modules #4438

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Publish javaagent bootstrap modules #4438

merged 1 commit into from
Oct 20, 2021

Conversation

trask
Copy link
Member

@trask trask commented Oct 20, 2021

No description provided.

@iNikem
Copy link
Contributor

iNikem commented Oct 20, 2021

Why? :)

@trask
Copy link
Member Author

trask commented Oct 20, 2021 •
edited
Loading

Why? :)

our distro pulls in individual instrumentations, so I need the new kafka bootstrap module in particular. i'm thinking to change our mechanism (e.g. using otel.instrumentation.common.default-enabled=false and enabling specific instrumentations), though I think these probably make sense to publish anyways since they are essentially dependencies of the javaagent instrumentation modules that we publish already

@mateuszrzeszutek
Copy link
Member

I think these probably make sense to publish anyways since they are essentially dependencies of the javaagent instrumentation modules that we publish already

💯

@trask trask merged commit 923797d into open-telemetry:main Oct 20, 2021
@trask trask deleted the publish-javaagent-bootstrap-modules branch October 20, 2021 16:28
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@trask @RashmiRam
Publish javaagent bootstrap modules (open-telemetry#4438)
a97e4b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurit laurit laurit approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@anuraaga anuraaga Awaiting requested review from anuraaga

@iNikem iNikem Awaiting requested review from iNikem

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trask @iNikem @mateuszrzeszutek @laurit