Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract net attributes both on start and on end in netty HTTP client #4420

Conversation

mateuszrzeszutek
Copy link
Member

Resolves #4408 - on the SIG meeting today we've decided to just extract those attributes both on start and end and stay with the current naming scheme.

@mateuszrzeszutek mateuszrzeszutek force-pushed the netty-client-capture-net-attributes-on-both branch from d7396f8 to 9afde26 Compare October 20, 2021 09:50
…o/opentelemetry/javaagent/instrumentation/netty/common/client/NettyNetClientAttributesExtractor.java

Co-authored-by: Trask Stalnaker <[email protected]>
@trask trask merged commit c490b29 into open-telemetry:main Oct 21, 2021
@mateuszrzeszutek mateuszrzeszutek deleted the netty-client-capture-net-attributes-on-both branch October 25, 2021 08:40
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
…pen-telemetry#4420)

* Extract net attributes both on start and on end in netty HTTP client

* storing remote address in HttpRequestAndChannel

* Update instrumentation/netty/netty-4-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/netty/common/client/NettyNetClientAttributesExtractor.java

Co-authored-by: Trask Stalnaker <[email protected]>

Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-think our net attributes extractors
4 participants