Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spring context reload issue (open-telemetry#3841) #4051

Merged
merged 2 commits into from
Sep 24, 2021
Merged

Fix spring context reload issue (open-telemetry#3841) #4051

merged 2 commits into from
Sep 24, 2021

Conversation

frommeyerc
Copy link
Contributor

I've created a small PR which will cause spring boot autoconfiguration not not register the OpenTelemetry Bean any more. If for a project some tracing would rely on the global registration of the bean this could be done in a second step manually, so this would still be supported.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 6, 2021

CLA Signed

The committers are authorized under a signed CLA.

@mateuszrzeszutek
Copy link
Member

Hey @frommeyerc ,
Thanks for your contribution! Can you sign the CLA?

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, not registering global seems like a good default for the spring starter

@iNikem iNikem merged commit ae7ad4b into open-telemetry:main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants