AHC: fill user agent #3930
Merged
AHC: fill user agent #3930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
requested review from
anuraaga,
iNikem,
jkwatson,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
approved these changes
Aug 25, 2021
mateuszrzeszutek
approved these changes
Aug 25, 2021
trask
approved these changes
Aug 26, 2021
instrumentation/async-http-client/async-http-client-2.0/javaagent/build.gradle.kts
Outdated
Show resolved
Hide resolved
| @Override | ||
| String userAgent() { | ||
| return "AHC" | ||
| } |
There was a problem hiding this comment.
no test changes for request/response content length?
There was a problem hiding this comment.
Completely forgot about these. Added verification for response content length. Didn't add verification for request content length because our tests don't have requests with body so this header is never set.
…ent/build.gradle.kts Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2347
Adds filling userAgent, requestContentLength and responseContentLength.